flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-10527) Cleanup constant isNewMode in YarnTestBase
Date Wed, 17 Oct 2018 07:26:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-10527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16653115#comment-16653115
] 

ASF GitHub Bot commented on FLINK-10527:
----------------------------------------

yanghua commented on issue #6816: [FLINK-10527] Cleanup constant isNewMode in YarnTestBase
URL: https://github.com/apache/flink/pull/6816#issuecomment-430519284
 
 
   Hi @zentol if you are not very busy, can you help me to look at this PR. It blocks FLINK-10292,
I think FLINK-10292 is very important because it is a whole with FLINK-10291.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Cleanup constant isNewMode in YarnTestBase
> ------------------------------------------
>
>                 Key: FLINK-10527
>                 URL: https://issues.apache.org/jira/browse/FLINK-10527
>             Project: Flink
>          Issue Type: Sub-task
>          Components: YARN
>            Reporter: vinoyang
>            Assignee: vinoyang
>            Priority: Major
>              Labels: pull-request-available
>
> This seems to be a residual problem with FLINK-10396. It is set to true in that PR. Currently
it has three usage scenarios:
> 1. assert, caused an error
> {code:java}
> assumeTrue("The new mode does not start TMs upfront.", !isNewMode);
> {code}
> 2. if (!isNewMode) the logic in the block would not have invoked, the if block can be
removed
> 3. if (isNewMode) always been invoked, the if statement can be removed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message