flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-10513) Replace TaskManagerActions#notifyFinalState with #updateTaskExecutionState
Date Mon, 08 Oct 2018 10:27:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-10513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16641635#comment-16641635
] 

ASF GitHub Bot commented on FLINK-10513:
----------------------------------------

tillrohrmann opened a new pull request #6804: [FLINK-10513] Replace TaskManagerActions#notifyFinalState
with #updateTaskExecutionState
URL: https://github.com/apache/flink/pull/6804
 
 
   ## What is the purpose of the change
   
   Simplify TaskManagerActions interface by replacing calls to notifyFinalState with
   updateTaskExecutionState.
   
   cc @TisonKun 
   
   ## Verifying this change
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing,
Yarn/Mesos, ZooKeeper: (no)
     - The S3 file system connector: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (no)
     - If yes, how is the feature documented? (not applicable)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Replace TaskManagerActions#notifyFinalState with #updateTaskExecutionState
> --------------------------------------------------------------------------
>
>                 Key: FLINK-10513
>                 URL: https://issues.apache.org/jira/browse/FLINK-10513
>             Project: Flink
>          Issue Type: Bug
>          Components: TaskManager
>    Affects Versions: 1.7.0
>            Reporter: Till Rohrmann
>            Assignee: Till Rohrmann
>            Priority: Minor
>              Labels: pull-request-available
>             Fix For: 1.7.0
>
>
> We can simplify the {{TaskManagerActions}} interface by replacing calls to the {{notifyFinalState}}
method by {{updateTaskExecutionState}}.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message