flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-10461) Speed up download file procedure when restore
Date Mon, 29 Oct 2018 15:32:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-10461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16667355#comment-16667355
] 

ASF GitHub Bot commented on FLINK-10461:
----------------------------------------

azagrebin commented on a change in pull request #6777: [FLINK-10461] [State Backends, Checkpointing]
Speed up download files when restore from DFS
URL: https://github.com/apache/flink/pull/6777#discussion_r228976096
 
 

 ##########
 File path: flink-state-backends/flink-statebackend-rocksdb/src/test/java/org/apache/flink/contrib/streaming/state/RocksDBStateDataTransferTest.java
 ##########
 @@ -0,0 +1,143 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.contrib.streaming.state;
+
+import org.apache.flink.core.fs.CloseableRegistry;
+import org.apache.flink.core.fs.FileSystem;
+import org.apache.flink.core.fs.Path;
+import org.apache.flink.runtime.state.IncrementalKeyedStateHandle;
+import org.apache.flink.runtime.state.StateHandleID;
+import org.apache.flink.runtime.state.StreamStateHandle;
+import org.apache.flink.runtime.state.memory.ByteStreamStateHandle;
+
+import org.junit.Rule;
+import org.junit.Test;
+import org.junit.rules.TemporaryFolder;
+
+import java.io.IOException;
+import java.io.InputStream;
+import java.util.HashMap;
+import java.util.Map;
+import java.util.Random;
+
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.fail;
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.when;
+
+/**
+ * Tests for RocksDbStateDataTransfer.
+ */
+public class RocksDBStateDataTransferTest {
+	@Rule
+	public TemporaryFolder temporaryFolder = new TemporaryFolder();
+
+	/**
+	 * Test that the exception arose in the thread pool will rethrow to the main thread.
+	 */
+	@Test
+	public void testThreadPoolExceptionRethrow() throws Exception {
+		IncrementalKeyedStateHandle stateHandle = mock(IncrementalKeyedStateHandle.class);
+
+		SpecifiedException expectedException = new SpecifiedException("throw exception while multi
thread restore.");
+		StreamStateHandle mockStateHandle = mock(StreamStateHandle.class);
+		when(mockStateHandle.openInputStream()).thenThrow(expectedException);
+
+		Map<StateHandleID, StreamStateHandle> sharedStateHandle = new HashMap<>(1);
+		sharedStateHandle.put(new StateHandleID("mock"), mockStateHandle);
+		when(stateHandle.getSharedState()).thenReturn(sharedStateHandle);
+
+		try {
+			RocksDbStateDataTransfer.transferAllStateDataToDirectory(stateHandle, new Path(temporaryFolder.newFolder().toURI()),
5, new CloseableRegistry());
+			fail();
+		} catch (Exception e) {
+			assertEquals(expectedException, e.getCause().getCause());
+		}
+	}
+
+	/**
+	 * Tests that download files with multi-thread correctly.
+	 * @throws Exception
+	 */
+	@Test
+	public void testMultiThreadRestoreCorrectly() throws Exception {
+		IncrementalKeyedStateHandle stateHandle = mock(IncrementalKeyedStateHandle.class);
+
+		byte[] content1 = new byte[1];
 
 Review comment:
   I would create a list of something like 6 test contexts and use loops over them for further
actions.
   content length can be also random.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Speed up download file procedure when restore 
> ----------------------------------------------
>
>                 Key: FLINK-10461
>                 URL: https://issues.apache.org/jira/browse/FLINK-10461
>             Project: Flink
>          Issue Type: Improvement
>          Components: State Backends, Checkpointing
>            Reporter: Congxian Qiu
>            Assignee: Congxian Qiu
>            Priority: Major
>              Labels: pull-request-available
>
> In the current master branch, the restore will download file from DFS, the download procedure
are single-thread, this could speed up by using multi-thread for downloading states from DFS.
>  
> In my company, the states will come to some terabytes, so the restore procedure will
become a litter slow, after a bit digging, I find download states from DFS using single thread,
this could using multi-thread for speed up.
> I test the time used for download states from DFS with ~2 terabytes states. With single
thread it used 640+s, and 130+s when using 5 threads for download.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message