flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-10386) Remove legacy class TaskExecutionStateListener
Date Thu, 04 Oct 2018 15:40:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-10386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16638391#comment-16638391

ASF GitHub Bot commented on FLINK-10386:

TisonKun commented on a change in pull request #6729: [FLINK-10386] [taskmanager] Remove legacy
class TaskExecutionStateListener
URL: https://github.com/apache/flink/pull/6729#discussion_r222721494

 File path: flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/tasks/StreamTaskTest.java
 @@ -181,43 +175,26 @@
 	public void testEarlyCanceling() throws Exception {
-		Deadline deadline = Deadline.fromNow(Duration.ofMinutes(2));
-		StreamConfig cfg = new StreamConfig(new Configuration());
+		final StreamConfig cfg = new StreamConfig(new Configuration());
 		cfg.setOperatorID(new OperatorID(4711L, 42L));
 		cfg.setStreamOperator(new SlowlyDeserializingOperator());
-		Task task = createTask(SourceStreamTask.class, cfg, new Configuration());
+		final TaskManagerActions taskManagerActions = mock(TaskManagerActions.class);
 Review comment:

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

> Remove legacy class TaskExecutionStateListener
> ----------------------------------------------
>                 Key: FLINK-10386
>                 URL: https://issues.apache.org/jira/browse/FLINK-10386
>             Project: Flink
>          Issue Type: Sub-task
>          Components: TaskManager
>    Affects Versions: 1.7.0
>            Reporter: tison
>            Assignee: tison
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.7.0
> After a discussion [here|https://github.com/apache/flink/commit/0735b5b935b0c0757943e2d58047afcfb9949560#commitcomment-30584257]
with [~trohrmann@apache.org]. I start to analyze the usage of {{ActorGatewayTaskExecutionStateListener}}
and {{TaskExecutionStateListener}}.
> In conclusion, we abort {{TaskExecutionStateListener}} strategy and no any component
rely on it. Instead, we introduce {{TaskManagerActions}} to take the role for the communication
of {{Task}} with {{TaskManager}}. No one except {{TaskManager}} should directly communicate
with {{Task}}. So it can be safely remove legacy class {{TaskExecutionStateListener}}.

This message was sent by Atlassian JIRA

View raw message