flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-9997) Improve Expression Reduce
Date Thu, 04 Oct 2018 13:53:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-9997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16638253#comment-16638253
] 

ASF GitHub Bot commented on FLINK-9997:
---------------------------------------

Xpray commented on a change in pull request #6455: [FLINK-9997] [table] Improve Expression
Reduce
URL: https://github.com/apache/flink/pull/6455#discussion_r222677511
 
 

 ##########
 File path: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/plan/ExpressionReductionRulesTest.scala
 ##########
 @@ -477,6 +476,22 @@ class ExpressionReductionRulesTest extends TableTestBase {
     util.verifyTable(result, expected)
   }
 
+  @Test
+  def testReduceDeterministicUDFInBatch(): Unit = {
+    val util = batchTestUtil()
+    val table = util.addTable[(Int, Long, String)]("MyTable", 'a, 'b, 'c)
+
+    // if isDeterministic = true, will cause a Calcite NPE, which will be fixed in [CALCITE-1860]
 
 Review comment:
   This comment can be removed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Improve Expression Reduce
> -------------------------
>
>                 Key: FLINK-9997
>                 URL: https://issues.apache.org/jira/browse/FLINK-9997
>             Project: Flink
>          Issue Type: Improvement
>          Components: Table API &amp; SQL
>            Reporter: Ruidong Li
>            Assignee: Ruidong Li
>            Priority: Major
>              Labels: pull-request-available
>
> There's no Calc node at normalize plans, so ReduceExpressionRule.CALC does not match
any thing.
> If adding calc-related rules to normalize phase, then project-related rules and filter-related
rules do not match any thing at logical opt phase. If adding ReduceExpressionRule.CALC to
logical opt phase, it will increase the the search time. Therefore, adding a new phase after
logical opt may be an option.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message