flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-7062) Support the basic functionality of MATCH_RECOGNIZE
Date Thu, 18 Oct 2018 08:02:05 GMT

    [ https://issues.apache.org/jira/browse/FLINK-7062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16654792#comment-16654792
] 

ASF GitHub Bot commented on FLINK-7062:
---------------------------------------

twalthr commented on a change in pull request #6815:  [FLINK-7062][cep][table] Added basic
support for MATCH_RECOGNIZE
URL: https://github.com/apache/flink/pull/6815#discussion_r225900996
 
 

 ##########
 File path: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/MatchRecognize.scala
 ##########
 @@ -0,0 +1,151 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.plan.nodes
+
+import com.google.common.collect.ImmutableMap
+import org.apache.calcite.rel.{RelCollation, RelWriter}
+import org.apache.calcite.rex.{RexCall, RexLiteral, RexNode}
+import org.apache.calcite.sql.SqlKind
+import org.apache.calcite.sql.SqlMatchRecognize.AfterOption
+import org.apache.flink.cep.nfa.aftermatch.AfterMatchSkipStrategy
+import org.apache.flink.table.plan.nodes.logical.FlinkLogicalMatch
+import org.apache.flink.table.plan.schema.RowSchema
+
+import scala.collection.JavaConverters._
+
+trait MatchRecognize {
+
+  private type JList[T] = java.util.List[T]
+  private type JSortedSet[T] = java.util.SortedSet[T]
+
+  private[flink] def partitionKeysToString(
+    keys: JList[RexNode],
+    schema: RowSchema,
+    expression: (RexNode, List[String], Option[List[RexNode]]) => String
+  ) = keys.asScala.map(k => expression(k, schema.fieldNames.toList, None)).mkString(",
")
+
+  private[flink] def orderingToString(orders: RelCollation, schema: RowSchema) =
+    orders.getFieldCollations.asScala.map {
+    x => schema.relDataType.getFieldList.get(x.getFieldIndex).getName
+  }.mkString(", ")
+
+  private[flink] def measuresDefineToString(
+      measures: ImmutableMap[String, RexNode],
+      schema: RowSchema,
+      expression: (RexNode, List[String], Option[List[RexNode]]) => String) =
+    measures.asScala.map {
+    case (k, v) => s"${expression(v, schema.fieldNames.toList, None)} AS $k"
 
 Review comment:
   As far as I can see it you are calling `schema.fieldNames` or `schema.relDataType.getFieldList.get(x.getFieldIndex).getName`
a couple of times in this class. Why not passing this directly?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Support the basic functionality of MATCH_RECOGNIZE
> --------------------------------------------------
>
>                 Key: FLINK-7062
>                 URL: https://issues.apache.org/jira/browse/FLINK-7062
>             Project: Flink
>          Issue Type: Sub-task
>          Components: CEP, Table API &amp; SQL
>            Reporter: Dian Fu
>            Assignee: Dian Fu
>            Priority: Major
>              Labels: pull-request-available
>
> In this JIRA, we will support the basic functionality of {{MATCH_RECOGNIZE}} in Flink
SQL API which includes the support of syntax {{MEASURES}}, {{PATTERN}} and {{DEFINE}}. This
would allow users write basic cep use cases with SQL like the following example:
> {code}
> SELECT T.aid, T.bid, T.cid
> FROM MyTable
> MATCH_RECOGNIZE (
>   MEASURES
>     A.id AS aid,
>     B.id AS bid,
>     C.id AS cid
>   PATTERN (A B C)
>   DEFINE
>     A AS A.name = 'a',
>     B AS B.name = 'b',
>     C AS C.name = 'c'
> ) AS T
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message