flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] ifndef-SleePy commented on issue #6770: [FLINK-10002] [Webfrontend] WebUI shows jm/tm logs more friendly.
Date Mon, 29 Oct 2018 09:01:14 GMT
ifndef-SleePy commented on issue #6770:  [FLINK-10002] [Webfrontend] WebUI shows jm/tm logs
more friendly.
URL: https://github.com/apache/flink/pull/6770#issuecomment-433834252
 
 
   > About the test, I don't find any tests for the REST API of logs. Should I add tests
for `JobManagerLogFileHandler`, `JobManagerLogListHandler`, `TaskManagerLogListHandler ` and
`TaskManagerLogFileHandler `?
   
   Yes, you should add some unit tests to make sure the basic logic is right. Some old codes
may not be covered well by testing. However the newer codes are covered quite well. We should
keep this good habit.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message