flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] GJL opened a new pull request #6915: [FLINK-10663][streaming] Fix NPE when StreamingFileSink is closed without initialization.
Date Wed, 24 Oct 2018 11:10:30 GMT
GJL opened a new pull request #6915: [FLINK-10663][streaming] Fix NPE when StreamingFileSink
is closed without initialization.
URL: https://github.com/apache/flink/pull/6915
 
 
   
   ## What is the purpose of the change
   
   *There is a potential NPE in the StreamingFileSink. If you don't want the NPE, this PR
should be merged.*
   
   cc: @kl0u 
   
   ## Brief change log
   
     - *Add null check to `StreamingFileSink#close()`.*
   
   ## Verifying this change
   
   This change added tests and can be verified as follows:
   
     - *Added unit test to `LocalStreamingFileSinkTest`.* 
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / **no**)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (**yes**
/ no)
     - The serializers: (yes / **no** / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing,
Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
     - The S3 file system connector: (yes / **no** / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes / **no**)
     - If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not
documented)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message