flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] StephanEwen commented on a change in pull request #6784: [FLINK-7811] Add support for Scala 2.12
Date Mon, 22 Oct 2018 19:55:27 GMT
StephanEwen commented on a change in pull request #6784: [FLINK-7811] Add support for Scala
2.12
URL: https://github.com/apache/flink/pull/6784#discussion_r227070724
 
 

 ##########
 File path: flink-formats/flink-avro/pom.xml
 ##########
 @@ -64,8 +64,7 @@ under the License.
 
 		<dependency>
 			<groupId>org.apache.flink</groupId>
-			<!-- use a dedicated Scala version to not depend on it -->
 
 Review comment:
   I think this is dangerous, because it means that the artifact we release have an undefined
Scala version - effectively whatever version we uploaded first (or last?).
   
   That means `flink-avro` 1.7 depends on Scala 2.11, `flink-avro` 1.8 might depend on Scala
2.12,  `flink-avro` 1.9 might depend again on Scala 2.11.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message