flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] ifndef-SleePy commented on a change in pull request #6770: [FLINK-10002] [Webfrontend] WebUI shows jm/tm logs more friendly.
Date Mon, 22 Oct 2018 10:02:31 GMT
ifndef-SleePy commented on a change in pull request #6770:  [FLINK-10002] [Webfrontend] WebUI
shows jm/tm logs more friendly.
URL: https://github.com/apache/flink/pull/6770#discussion_r226235403
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/legacy/files/StaticFileServerHandler.java
 ##########
 @@ -104,6 +106,8 @@
 	/** Be default, we allow files to be cached for 5 minutes. */
 	private static final int HTTP_CACHE_SECONDS = 300;
 
+	private static final Pattern currentLogPattern = Pattern.compile("^/jobmanager/(log|stdout)(/([^/]*))?$");
 
 Review comment:
   I think we should not use `StaticFileServerHandler` to process log file anymore.
   The log request would be served by other log handler.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message