flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] tillrohrmann commented on issue #6755: [FLINK-10412] toString field in AbstractID should be transient to avoid been serialized
Date Fri, 19 Oct 2018 09:59:48 GMT
tillrohrmann commented on issue #6755: [FLINK-10412] toString field in AbstractID should be
transient to avoid been serialized
URL: https://github.com/apache/flink/pull/6755#issuecomment-431311897
 
 
   As of this [documentation](https://docs.oracle.com/javase/8/docs/platform/serialization/spec/version.html#a6519),
making a nontransient field transient is identical as removing a field from a class. What
happens is that an earlier version won't find the field data in the serialized stream and
will initialize the field with the default value (`null`). In general this is an incompatible
change when relying on Java serialization, however in our case if `toString == null`, then
we will simply regenerate the `toString` field when calling `toString`. Therefore, I think
it is ok to merge this change. 
   
   I will proceed with merging.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message