flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] ifndef-SleePy commented on a change in pull request #6770: [FLINK-10002] [Webfrontend] WebUI shows jm/tm logs more friendly.
Date Fri, 19 Oct 2018 07:50:15 GMT
ifndef-SleePy commented on a change in pull request #6770:  [FLINK-10002] [Webfrontend] WebUI
shows jm/tm logs more friendly.
URL: https://github.com/apache/flink/pull/6770#discussion_r226549357
 
 

 ##########
 File path: flink-runtime/src/main/scala/org/apache/flink/runtime/messages/TaskManagerMessages.scala
 ##########
 @@ -117,11 +118,13 @@ object TaskManagerMessages {
   /** Trait do differentiate which log file is requested */
   sealed trait LogTypeRequest
 
-  /** Indicates a request for the .log file */
-  case object LogFileRequest extends LogTypeRequest
+  /** Indicates a request for the log file */
+  case class LogFileRequest(filename : String, range: FileOffsetRange) extends LogTypeRequest
 
 Review comment:
   Just leave the legacy codes alone.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message