flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] ifndef-SleePy commented on a change in pull request #6770: [FLINK-10002] [Webfrontend] WebUI shows jm/tm logs more friendly.
Date Fri, 19 Oct 2018 07:50:15 GMT
ifndef-SleePy commented on a change in pull request #6770:  [FLINK-10002] [Webfrontend] WebUI
shows jm/tm logs more friendly.
URL: https://github.com/apache/flink/pull/6770#discussion_r226525650

 File path: flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/RangePathParameter.java
 @@ -0,0 +1,47 @@
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.flink.runtime.rest.messages;
+import org.apache.flink.runtime.rest.handler.legacy.files.FileOffsetRange;
+ * Path parameter identifying the offset range of a log file to read.
+ */
+public class RangePathParameter extends MessagePathParameter<FileOffsetRange> {
 Review comment:
   I prefer treat 'range' as a `MessageQueryParameter`.
   It would be better that range is an optional parameter. If there is no range parameter,
we can just return the whole log file. It is compatible with the old API.
   The RESTful API should be like "/xxx/taskmanager/$filename?start=123&size=456"

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

With regards,
Apache Git Services

View raw message