flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] pnowojski commented on a change in pull request #6776: [FLINK-9715][table] Support temporal join with event time
Date Wed, 17 Oct 2018 09:45:30 GMT
pnowojski commented on a change in pull request #6776: [FLINK-9715][table] Support temporal
join with event time
URL: https://github.com/apache/flink/pull/6776#discussion_r225844025
 
 

 ##########
 File path: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/join/TemporalRowtimeJoin.scala
 ##########
 @@ -237,15 +238,17 @@ class TemporalRowtimeJoin(
     * be joined with it later
     */
   private def cleanUpState(timerTimestamp: Long, rightRowsSorted: util.List[Row]) = {
-    for (i <- 0 until firstIndexToKeep(timerTimestamp, rightRowsSorted)) {
+    var i = 0
+    while (i < firstIndexToKeep(timerTimestamp, rightRowsSorted)) {
 
 Review comment:
   Ok changed, however, it shouldn't matter here.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message