flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] fhueske commented on a change in pull request #6823: [FLINK-10134] UTF-16 support for TextInputFormat bug refixed
Date Tue, 16 Oct 2018 15:08:19 GMT
fhueske commented on a change in pull request #6823: [FLINK-10134] UTF-16 support for TextInputFormat
bug refixed
URL: https://github.com/apache/flink/pull/6823#discussion_r225547062
 
 

 ##########
 File path: flink-core/src/main/java/org/apache/flink/api/common/io/DelimitedInputFormat.java
 ##########
 @@ -215,6 +240,7 @@ public Charset getCharset() {
 	public void setCharset(String charset) {
 		this.charsetName = Preconditions.checkNotNull(charset);
 		this.charset = null;
+		this.bomCharset = null;
 
 		if (this.delimiterString != null) {
 			this.delimiter = delimiterString.getBytes(getCharset());
 
 Review comment:
   We can remove this here. We can only configure the delimiter once we know the definitive
charset.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message