flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] zentol commented on a change in pull request #6850: [FLINK-10252] Handle oversized metric messges
Date Tue, 16 Oct 2018 08:47:07 GMT
zentol commented on a change in pull request #6850: [FLINK-10252] Handle oversized metric messges
URL: https://github.com/apache/flink/pull/6850#discussion_r225449312
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/metrics/dump/MetricQueryService.java
 ##########
 @@ -109,7 +122,17 @@ public void onReceive(Object message) {
 				}
 			} else if (message instanceof CreateDump) {
 				MetricDumpSerialization.MetricSerializationResult dump = serializer.serialize(counters,
gauges, histograms, meters);
-				getSender().tell(dump, getSelf());
+
+				int realMsgSize = dump.serializedMetrics.length;
+
+				if (realMsgSize > maximumFramesize) {
+					String overSizeErrorMsg = "The metric dump message size : " + realMsgSize
+						+ " exceeds the maximum akka framesize : " + maximumFramesize + ".";
+					LOG.error(overSizeErrorMsg);
+					getSender().tell(new Status.Failure(new IOException(overSizeErrorMsg)), getSelf());
 
 Review comment:
   While better than crashing a more reasonable option might be to create a new dump with
reduced number of metrics.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message