flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] sjwiesman commented on a change in pull request #6814: [FLINK-10423][rocksdb][metrics] rocksdb native metrics monitor
Date Fri, 12 Oct 2018 17:03:04 GMT
sjwiesman commented on a change in pull request #6814: [FLINK-10423][rocksdb][metrics] rocksdb
native metrics monitor
URL: https://github.com/apache/flink/pull/6814#discussion_r224854199
 
 

 ##########
 File path: flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBKeyedStateBackend.java
 ##########
 @@ -606,6 +627,17 @@ private RocksDB openDB(
 		Preconditions.checkState(1 + stateColumnFamilyDescriptors.size() == stateColumnFamilyHandles.size(),
 			"Not all requested column family handles have been created");
 
+		if (this.metricOptions.isEnabled()) {
+			this.nativeMetricMonitor = new RocksDBNativeMetricMonitor(
+				dbRef,
+				rocksDBResourceGuard,
+				metricOptions,
+				operatorMetricGroup
+			);
+
+			this.cancelStreamRegistry.registerCloseable(nativeMetricMonitor);
 
 Review comment:
   Why is this an issue? The cancelStreamRegistry is closed in `AbstractKeyedStateBackend#dispose`.
 I manually called close inside of `dispose` first but I was concerned about the strict ordering
it imposed because if the nativeMetricsWatcher wasn't closed first `rocksDBResourceGuard.close()`
would block forever. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message