flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] zentol commented on a change in pull request #6702: [FLINK-10135] The JobManager does not report the cluster-level metrics
Date Tue, 09 Oct 2018 11:18:21 GMT
zentol commented on a change in pull request #6702: [FLINK-10135] The JobManager does not report
the cluster-level metrics
URL: https://github.com/apache/flink/pull/6702#discussion_r223627081
 
 

 ##########
 File path: flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/MesosResourceManagerFactory.java
 ##########
 @@ -62,7 +63,17 @@ public MesosResourceManagerFactory(@Nonnull MesosServices mesosServices,
@Nonnul
 	}
 
 	@Override
-	public ResourceManager<RegisteredMesosWorkerNode> createResourceManager(Configuration
configuration, ResourceID resourceId, RpcService rpcService, HighAvailabilityServices highAvailabilityServices,
HeartbeatServices heartbeatServices, MetricRegistry metricRegistry, FatalErrorHandler fatalErrorHandler,
ClusterInformation clusterInformation, @Nullable String webInterfaceUrl) throws Exception
{
+	public ResourceManager<RegisteredMesosWorkerNode> createResourceManager(
+		Configuration configuration,
+		ResourceID resourceId,
+		RpcService rpcService,
 
 Review comment:
   please indent the arguments by another tab to separate them from the constructor body.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message