flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] zhijiangW commented on a change in pull request #6698: [FLINK-8581][network] Move flushing remote subpartitions from OutputFlusher to netty
Date Tue, 09 Oct 2018 03:43:32 GMT
zhijiangW commented on a change in pull request #6698: [FLINK-8581][network] Move flushing
remote subpartitions from OutputFlusher to netty
URL: https://github.com/apache/flink/pull/6698#discussion_r223553034
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/PartitionRequestQueue.java
 ##########
 @@ -354,4 +404,64 @@ public void operationComplete(ChannelFuture future) throws Exception
{
 			}
 		}
 	}
+
+	private static class RegisterPeriodicFlushEvent {
+		private final NetworkSequenceViewReader reader;
+		private final long flushTimeout;
+
+		public RegisterPeriodicFlushEvent(NetworkSequenceViewReader reader, long flushTimeout)
{
+			this.reader = checkNotNull(reader);
+			this.flushTimeout = flushTimeout;
+		}
+
+		public NetworkSequenceViewReader getReader() {
+			return reader;
+		}
+
+		public long getFlushTimeout() {
+			return flushTimeout;
+		}
+	}
+
+	private static class PeriodicFlushes {
+		private final Map<Long, List<NetworkSequenceViewReader>> periodicFlushes =
new HashMap<>();
+		private final Map<NetworkSequenceViewReader, Long> flushTimeouts = new HashMap<>();
+		private final Map<Long, ScheduledFuture<?>> scheduledEvents = new HashMap<>();
+
+		public void register(ChannelHandlerContext ctx, long flushTimeout, NetworkSequenceViewReader
reader) {
+			checkState(!flushTimeouts.containsKey(reader));
+			checkState(flushTimeout > 0);
 
 Review comment:
   If we check the `flushTimeout` at the beginning in `ResultPartition` stack as mentioned
above, we need not care about it in the following processes.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message