flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] tillrohrmann commented on issue #6804: [FLINK-10513] Replace TaskManagerActions#notifyFinalState with #updateTaskExecutionState
Date Mon, 08 Oct 2018 12:07:36 GMT
tillrohrmann commented on issue #6804: [FLINK-10513] Replace TaskManagerActions#notifyFinalState
with #updateTaskExecutionState
URL: https://github.com/apache/flink/pull/6804#issuecomment-427808601
 
 
   I would not inline it, because `notifyFinalState` gives a little bit more context (namely
that we've reached the final state) also implying that you should not call it if you haven't
reached a final state yet. But it is mainly a matter of taste, I agree.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message