flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] xccui commented on a change in pull request #6700: [FLINK-10340][table] Add Cosh math function supported in Table API and SQL
Date Tue, 02 Oct 2018 21:57:05 GMT
xccui commented on a change in pull request #6700: [FLINK-10340][table] Add Cosh math function
supported in Table API and SQL
URL: https://github.com/apache/flink/pull/6700#discussion_r222125558
 
 

 ##########
 File path: docs/dev/table/functions.md
 ##########
 @@ -1274,6 +1274,17 @@ ATAN2(numeric1, numeric2)
       </td>
     </tr>
 
+    <tr>
+      <td>
+        {% highlight text %}
+COSH(numeric)
+{% endhighlight %}
+      </td>
+      <td>
+        <p>Returns the hyperbolic cosine of <i>numeric</i>. Return value
type is DOUBLE.</p>
 
 Review comment:
   Hi @pnowojski, yes, it's necessary to mark the data types of the functions' inputs/output,
but maybe not inline with the description. I think it's better to assign separate columns
for that. Anyway, incrementally adding the return types is not bad to me and we need to go
over the whole function list at a time in the future.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message