flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] GJL commented on a change in pull request #6785: [FLINK-10309][rest] Before shutting down cluster, wait for asynchronous operations
Date Tue, 02 Oct 2018 12:58:40 GMT
GJL commented on a change in pull request #6785: [FLINK-10309][rest] Before shutting down cluster,
wait for asynchronous operations
URL: https://github.com/apache/flink/pull/6785#discussion_r221939470
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/job/AsynchronousJobOperationKey.java
 ##########
 @@ -33,7 +33,7 @@
  * A pair of {@link JobID} and {@link TriggerId} used as a key to a hash based
  * collection.
  *
- * @see AbstractAsynchronousOperationHandlers.CompletedOperationCache
+ * @see AbstractAsynchronousOperationHandlers
 
 Review comment:
   It's not possible to reference the cache anymore because it has default visibility now.
I also don't think it is necessary to reference it here to understand how `AsynchronousJobOperationKey`
is used.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message