From issues-return-188431-archive-asf-public=cust-asf.ponee.io@flink.apache.org Fri Sep 14 12:00:11 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 5A8C9180647 for ; Fri, 14 Sep 2018 12:00:11 +0200 (CEST) Received: (qmail 49444 invoked by uid 500); 14 Sep 2018 10:00:10 -0000 Mailing-List: contact issues-help@flink.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.apache.org Delivered-To: mailing list issues@flink.apache.org Received: (qmail 49434 invoked by uid 99); 14 Sep 2018 10:00:10 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 14 Sep 2018 10:00:10 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 00630C8D2B for ; Fri, 14 Sep 2018 10:00:10 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.501 X-Spam-Level: X-Spam-Status: No, score=-109.501 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id 2C4BlqsN8MeE for ; Fri, 14 Sep 2018 10:00:09 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id B6C7A5F4A9 for ; Fri, 14 Sep 2018 10:00:08 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 10194E25B0 for ; Fri, 14 Sep 2018 10:00:08 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id B251F23FA2 for ; Fri, 14 Sep 2018 10:00:07 +0000 (UTC) Date: Fri, 14 Sep 2018 10:00:07 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@flink.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (FLINK-10290) Conversion error in StreamScan and BatchScan MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/FLINK-10290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16614617#comment-16614617 ] ASF GitHub Bot commented on FLINK-10290: ---------------------------------------- jrthe42 commented on a change in pull request #6666: [FLINK-10290] [table] Fix conversion error in StreamScan and BatchScan URL: https://github.com/apache/flink/pull/6666#discussion_r217662930 ########## File path: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/stream/table/TableSourceITCase.scala ########## @@ -778,4 +778,42 @@ class TableSourceITCase extends AbstractTestBase { assertEquals(expected.sorted, StreamITCase.testResults.sorted) } + @Test + def testTableSourceScanWithConversion(): Unit = { Review comment: Agree! Will rename this test. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org > Conversion error in StreamScan and BatchScan > -------------------------------------------- > > Key: FLINK-10290 > URL: https://issues.apache.org/jira/browse/FLINK-10290 > Project: Flink > Issue Type: Bug > Components: Table API & SQL > Affects Versions: 1.5.3, 1.6.0 > Reporter: wangsan > Assignee: wangsan > Priority: Major > Labels: pull-request-available > > `RowTypeInfo#equals()` only compares field types, and fields names are not considered. When checking the equality of `inputType` and `internalType`, we should compare both filed types and field names. > Behavior of this bug: > A table T with schema (a: Long, b:Long, c:Long) > SELECT b,c,a from T > expected: b,c,a > actually: a,b,c -- This message was sent by Atlassian JIRA (v7.6.3#76005)