From issues-return-189968-archive-asf-public=cust-asf.ponee.io@flink.apache.org Sat Sep 22 19:17:59 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id B807118065B for ; Sat, 22 Sep 2018 19:17:58 +0200 (CEST) Received: (qmail 61449 invoked by uid 500); 22 Sep 2018 17:17:57 -0000 Mailing-List: contact issues-help@flink.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.apache.org Delivered-To: mailing list issues@flink.apache.org Received: (qmail 61437 invoked by uid 99); 22 Sep 2018 17:17:57 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 22 Sep 2018 17:17:57 +0000 From: GitBox To: issues@flink.apache.org Subject: [GitHub] tillrohrmann opened a new pull request #6734: [FLINK-9455][RM] Add support for multi task slot TaskExecutors Message-ID: <153763667729.7934.2205277396485396293.gitbox@gitbox.apache.org> Date: Sat, 22 Sep 2018 17:17:57 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit tillrohrmann opened a new pull request #6734: [FLINK-9455][RM] Add support for multi task slot TaskExecutors URL: https://github.com/apache/flink/pull/6734 ## What is the purpose of the change This PR adds support for multi task slot TaskExecutors to Flink. Before it was recommended to start a Flink cluster with single slot `TaskExecutors`. Now also multi slot `TaskExecutors` can be configured and Flink won't allocate resources over-excessively. ## Brief change log - Extend `ResourceActions#allocateResource` to return `Collection` indicating the set of slots to expect - Store expected slots as `PendingTaskManagerSlot` - Use `PendingTaskManagerSlot` to fulfill `PendingSlotRequest` - Only ask for new resources if there are no more `TaskManagerSlots` and `PendingTaskManagerSlots` ## Verifying this change - Added `SlotManagerTest#`: `testRequestNewResources`, `testFailingAllocationReturnsPendingTaskManagerSlot`, `testPendingTaskManagerSlotCompletion`, `testRegistrationOfDifferentSlot`, `testOnlyFreeSlotsCanFulfillPendingTaskManagerSlot`, ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): (no) - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no) - The serializers: (no) - The runtime per-record code paths (performance sensitive): (no) - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (**yes**) - The S3 file system connector: (no) ## Documentation - Does this pull request introduce a new feature? (no) - If yes, how is the feature documented? (not applicable) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services