From issues-return-189799-archive-asf-public=cust-asf.ponee.io@flink.apache.org Fri Sep 21 09:26:03 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 22C66180677 for ; Fri, 21 Sep 2018 09:26:02 +0200 (CEST) Received: (qmail 50363 invoked by uid 500); 21 Sep 2018 07:26:01 -0000 Mailing-List: contact issues-help@flink.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.apache.org Delivered-To: mailing list issues@flink.apache.org Received: (qmail 50336 invoked by uid 99); 21 Sep 2018 07:26:01 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 21 Sep 2018 07:26:01 +0000 From: GitBox To: issues@flink.apache.org Subject: [GitHub] twalthr commented on a change in pull request #6299: [FLINK-9713][table][sql] Support processing time versioned joins Message-ID: <153751476119.29911.6867102792177870786.gitbox@gitbox.apache.org> Date: Fri, 21 Sep 2018 07:26:01 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit twalthr commented on a change in pull request #6299: [FLINK-9713][table][sql] Support processing time versioned joins URL: https://github.com/apache/flink/pull/6299#discussion_r219405006 ########## File path: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/calcite/RelTimeIndicatorConverter.scala ########## @@ -175,13 +173,41 @@ class RelTimeIndicatorConverter(rexBuilder: RexBuilder) extends RelShuttle { val rewrittenTemporalJoin = temporalJoin.copy(temporalJoin.getTraitSet, List(left, right)) - // Materialize all of the time attributes from the right side of temporal join - val indicesToMaterialize = - (left.getRowType.getFieldCount until rewrittenTemporalJoin.getRowType.getFieldCount).toSet + val indicesToMaterialize = gatherIndicesToMaterialize(rewrittenTemporalJoin, left, right) materializerUtils.projectAndMaterializeFields(rewrittenTemporalJoin, indicesToMaterialize) } + private def gatherIndicesToMaterialize( Review comment: nit: put private methods below public methods ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services