From issues-return-189243-archive-asf-public=cust-asf.ponee.io@flink.apache.org Tue Sep 18 17:53:15 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 44E871807BD for ; Tue, 18 Sep 2018 17:53:12 +0200 (CEST) Received: (qmail 36222 invoked by uid 500); 18 Sep 2018 15:53:10 -0000 Mailing-List: contact issues-help@flink.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.apache.org Delivered-To: mailing list issues@flink.apache.org Received: (qmail 35590 invoked by uid 99); 18 Sep 2018 15:53:10 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 18 Sep 2018 15:53:10 +0000 From: GitBox To: issues@flink.apache.org Subject: [GitHub] pnowojski commented on a change in pull request #6299: [FLINK-9713][table][sql] Support processing time versioned joins Message-ID: <153728599011.13051.14468047635061780239.gitbox@gitbox.apache.org> Date: Tue, 18 Sep 2018 15:53:10 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit pnowojski commented on a change in pull request #6299: [FLINK-9713][table][sql] Support processing time versioned joins URL: https://github.com/apache/flink/pull/6299#discussion_r218374441 ########## File path: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/logical/operators.scala ########## @@ -678,6 +678,32 @@ case class WindowAggregate( } } +case class TemporalTable( Review comment: `Constructor` is inconsistent with other case classes here. This is behaviour is already quite clearly visible in this class ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services