From issues-return-188557-archive-asf-public=cust-asf.ponee.io@flink.apache.org  Fri Sep 14 15:48:56 2018
Return-Path: <issues-return-188557-archive-asf-public=cust-asf.ponee.io@flink.apache.org>
X-Original-To: archive-asf-public@cust-asf.ponee.io
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by mx-eu-01.ponee.io (Postfix) with SMTP id 4411118067E
	for <archive-asf-public@cust-asf.ponee.io>; Fri, 14 Sep 2018 15:48:56 +0200 (CEST)
Received: (qmail 93489 invoked by uid 500); 14 Sep 2018 13:48:55 -0000
Mailing-List: contact issues-help@flink.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:issues-help@flink.apache.org>
List-Unsubscribe: <mailto:issues-unsubscribe@flink.apache.org>
List-Post: <mailto:issues@flink.apache.org>
List-Id: <issues.flink.apache.org>
Reply-To: dev@flink.apache.org
Delivered-To: mailing list issues@flink.apache.org
Received: (qmail 93474 invoked by uid 99); 14 Sep 2018 13:48:55 -0000
Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 14 Sep 2018 13:48:55 +0000
From: GitBox <git@apache.org>
To: issues@flink.apache.org
Subject: [GitHub] kl0u commented on a change in pull request #6646: [FLINK-10050]
 Support allowedLateness in CoGroupedStreams
Message-ID: <153693293484.28879.6306643038692171809.gitbox@gitbox.apache.org>
Date: Fri, 14 Sep 2018 13:48:54 -0000
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit

kl0u commented on a change in pull request #6646: [FLINK-10050] Support allowedLateness in CoGroupedStreams
URL: https://github.com/apache/flink/pull/6646#discussion_r217716951
 
 

 ##########
 File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/datastream/CoGroupedStreams.java
 ##########
 @@ -254,7 +260,17 @@ protected WithWindow(DataStream<T1> input1,
 		@PublicEvolving
 		public WithWindow<T1, T2, KEY, W> evictor(Evictor<? super TaggedUnion<T1, T2>, ? super W> newEvictor) {
 			return new WithWindow<>(input1, input2, keySelector1, keySelector2, keyType,
-					windowAssigner, trigger, newEvictor);
+					windowAssigner, trigger, newEvictor, allowedLateness);
+		}
+
+		/**
+		 * Sets the time by which elements are allowed to be late.
+		 * @see WindowedStream#allowedLateness(Time)
+		 */
+		@PublicEvolving
+		public WithWindow<T1, T2, KEY, W> allowedLateness(Time newLateness) {
+			return new WithWindow<>(input1, input2, keySelector1, keySelector2, keyType,
 
 Review comment:
   Check for `null`. If the user calls `allowedLateness`, he should not pass a `null` value.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services