From issues-return-188469-archive-asf-public=cust-asf.ponee.io@flink.apache.org Fri Sep 14 14:16:51 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id E42571807AC for ; Fri, 14 Sep 2018 14:16:47 +0200 (CEST) Received: (qmail 9337 invoked by uid 500); 14 Sep 2018 12:16:41 -0000 Mailing-List: contact issues-help@flink.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.apache.org Delivered-To: mailing list issues@flink.apache.org Received: (qmail 9010 invoked by uid 99); 14 Sep 2018 12:16:41 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 14 Sep 2018 12:16:41 +0000 From: GitBox To: issues@flink.apache.org Subject: [GitHub] twalthr commented on a change in pull request #6299: [FLINK-9713][table][sql] Support processing time versioned joins Message-ID: <153692740087.26224.1551439131447858997.gitbox@gitbox.apache.org> Date: Fri, 14 Sep 2018 12:16:40 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit twalthr commented on a change in pull request #6299: [FLINK-9713][table][sql] Support processing time versioned joins URL: https://github.com/apache/flink/pull/6299#discussion_r217393776 ########## File path: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/calcite/RelTimeIndicatorConverter.scala ########## @@ -400,6 +411,10 @@ class RexTimeIndicatorMaterializer( // materialize operands with time indicators val materializedOperands = updatedCall.getOperator match { + case tableFunction: TableSqlFunction Review comment: Additionally, for the future event-time case, add a dedicated test case to `TimeAttributesITCase`. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services