flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-10451) TableFunctionCollector should handle the life cycle of ScalarFunction
Date Thu, 27 Sep 2018 10:54:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-10451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16630193#comment-16630193
] 

ASF GitHub Bot commented on FLINK-10451:
----------------------------------------

Xpray opened a new pull request #6771: [FLINK-10451] [table] TableFunctionCollector should
handle the life cycle of ScalarFunction
URL: https://github.com/apache/flink/pull/6771
 
 
   ## What is the purpose of the change
   
   TableFunctionCollector should handle the life cycle of ScalarFunction
   
   ## Brief change log
   
   * Make `TableFunctionCollector` extends `AbstractRichFunction`
   * do open() and close()
   
   
   ## Verifying this change
   
   This change added tests and can be verified as follows:
   * `org.apache.flink.table.runtime.batch.table.CorrelateITCase#testTableFunctionWithFilterInside`
   * `org.apache.flink.table.runtime.stream.table.CorrelateITCase#testTableFunctionWithFilterInside`
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency):  no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`:  no
     - The serializers:  no
     - The runtime per-record code paths (performance sensitive):  no
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing,
Yarn/Mesos, ZooKeeper:  no
     - The S3 file system connector:  no
   
   ## Documentation
   
     - Does this pull request introduce a new feature?  no
     - If yes, how is the feature documented?  not documented
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> TableFunctionCollector should handle the life cycle of ScalarFunction
> ---------------------------------------------------------------------
>
>                 Key: FLINK-10451
>                 URL: https://issues.apache.org/jira/browse/FLINK-10451
>             Project: Flink
>          Issue Type: Bug
>          Components: Table API &amp; SQL
>            Reporter: Ruidong Li
>            Assignee: Ruidong Li
>            Priority: Major
>              Labels: pull-request-available
>
> Considering the following query:
> table.join(udtf('a)).where(udf('b))
> the filter will be pushed into DataSetCorrelate/DataStreamCorrelate without triggering
open() and close()



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message