flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-10415) RestClient does not react to lost connection
Date Thu, 27 Sep 2018 14:09:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-10415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16630479#comment-16630479
] 

ASF GitHub Bot commented on FLINK-10415:
----------------------------------------

tillrohrmann commented on issue #6763: [FLINK-10415] Fail response future if connection closes
in RestClient
URL: https://github.com/apache/flink/pull/6763#issuecomment-425106479
 
 
   Thanks again for the review @zentol. I had to add the `IdleStateHandler` because it happened
sometimes in `RestClientTest#testConnectionClosedHandling` that the channel would not be closed
by Netty after we closed the server socket. So sometimes Netty detects such an event and then
calls `channelInactive` and sometimes not. For the latter case, we need to monitor the connection
for idleness.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> RestClient does not react to lost connection
> --------------------------------------------
>
>                 Key: FLINK-10415
>                 URL: https://issues.apache.org/jira/browse/FLINK-10415
>             Project: Flink
>          Issue Type: Bug
>          Components: REST
>    Affects Versions: 1.6.1, 1.7.0, 1.5.4
>            Reporter: Till Rohrmann
>            Assignee: Till Rohrmann
>            Priority: Blocker
>              Labels: pull-request-available
>             Fix For: 1.7.0, 1.6.2, 1.5.5
>
>
> While working on FLINK-10403, I noticed that Flink's {{RestClient}} does not seem to
react to a lost connections in time. When sending a request to the current leader it happened
that the leader was killed just after establishing the connection. Then the {{RestClient}}
did not fail the connection and was stuck in writing a request or retrieving a response from
the lost leader. I'm wondering whether we should introduce a {{ReadTimeoutHandler}} and {{WriteTimeoutHandler}}
to handle these problems.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message