flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-10400) Return failed JobResult if job terminates in state FAILED or CANCELED
Date Mon, 24 Sep 2018 14:35:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-10400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16625902#comment-16625902
] 

ASF GitHub Bot commented on FLINK-10400:
----------------------------------------

tillrohrmann opened a new pull request #6742: [FLINK-10400] Fail JobResult if application
finished in CANCELED or FAILED state
URL: https://github.com/apache/flink/pull/6742
 
 
   ## What is the purpose of the change
   
   When generating a `JobExecutionResult` from a `JobResult`, we fail the conversion if the
application status was not `SUCCEEDED`.
   
   In case of the CANCELED state, the client will throw an JobCancellationException.
   In case of the FAILED state, the client will throw an JobExecutionException.
   
   ## Brief change log
   
   - Add `ApplicationStatus` field to `JobResult`
   - Throw `JobCancellationException` if `ApplicationStatus` was `CANCELED`
   - Throw `JobExecutionException` if `ApplicationStatus` was `FAILED`
   
   ## Verifying this change
   
   - Added `JobResultTest#testCancelledJobIsFailureResult`, `#testFailedJobIsFailureResult`,
`#testCancelledJobThrowsJobCancellationException` and `#testFailedJobThrowsJobExecutionException`.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing,
Yarn/Mesos, ZooKeeper: (no)
     - The S3 file system connector: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (no)
     - If yes, how is the feature documented? (not applicable)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Return failed JobResult if job terminates in state FAILED or CANCELED
> ---------------------------------------------------------------------
>
>                 Key: FLINK-10400
>                 URL: https://issues.apache.org/jira/browse/FLINK-10400
>             Project: Flink
>          Issue Type: Bug
>          Components: Client
>    Affects Versions: 1.6.1, 1.7.0, 1.5.4
>            Reporter: Till Rohrmann
>            Assignee: Till Rohrmann
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.7.0, 1.6.2, 1.5.5
>
>
> If the job reaches the globally terminal state {{FAILED}} or {{CANCELED}}, the {{JobResult}}
must return a non-successful result. At the moment, it can happen that in the {{CANCELED}}
state where we don't find a failure cause that we return a successful {{JobResult}}.
> In order to change this I propose to always return a {{JobResult}} with a {{JobCancellationException}}
in case of {{CANCELED}} and a {{JobExecutionException}} in case of {{FAILED}}.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message