flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-10389) TaskManagerServicesConfiguration ctor contains self assignment
Date Mon, 24 Sep 2018 13:04:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-10389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16625790#comment-16625790
] 

ASF GitHub Bot commented on FLINK-10389:
----------------------------------------

zentol closed pull request #6740: [FLINK-10389] TaskManagerServicesConfiguration ctor contains
self assignment
URL: https://github.com/apache/flink/pull/6740
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskManagerServicesConfiguration.java
b/flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskManagerServicesConfiguration.java
index eec39ef2975..c27e54d7649 100644
--- a/flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskManagerServicesConfiguration.java
+++ b/flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskManagerServicesConfiguration.java
@@ -85,8 +85,6 @@
 
 	private final boolean localRecoveryEnabled;
 
-	private boolean systemResourceMetricsEnabled;
-
 	private Optional<Time> systemResourceMetricsProbingInterval;
 
 	public TaskManagerServicesConfiguration(
@@ -121,7 +119,6 @@ public TaskManagerServicesConfiguration(
 			"service shutdown timeout must be greater or equal to 0.");
 		this.timerServiceShutdownTimeout = timerServiceShutdownTimeout;
 
-		this.systemResourceMetricsEnabled = systemResourceMetricsEnabled;
 		this.systemResourceMetricsProbingInterval = checkNotNull(systemResourceMetricsProbingInterval);
 	}
 


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> TaskManagerServicesConfiguration ctor contains self assignment
> --------------------------------------------------------------
>
>                 Key: FLINK-10389
>                 URL: https://issues.apache.org/jira/browse/FLINK-10389
>             Project: Flink
>          Issue Type: Task
>    Affects Versions: 1.7.0
>            Reporter: Ted Yu
>            Assignee: vinoyang
>            Priority: Minor
>              Labels: pull-request-available
>             Fix For: 1.7.0
>
>
> TaskManagerServicesConfiguration has:
> {code}
>     this.systemResourceMetricsEnabled = systemResourceMetricsEnabled;
> {code}
> There is no systemResourceMetricsEnabled parameter to the ctor.
> This was reported by findbugs.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message