flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-10358) Flink kinesis connector could throw NPE during getRecords() call
Date Wed, 19 Sep 2018 16:46:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-10358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16620832#comment-16620832
] 

ASF GitHub Bot commented on FLINK-10358:
----------------------------------------

yxu-valleytider commented on issue #6708: [FLINK-10358][Kinesis-connector] fix NPE in case
millisBehindLatest is null
URL: https://github.com/apache/flink/pull/6708#issuecomment-422874733
 
 
   @mxm  We do plan to contribute the efforts of consuming from dynamodb streams (Flink-4582)
back to upstream flink.  This patch is needed for our internal testing. And we strive to keep
upstream flink and our internal fork as consistent as possible. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Flink kinesis connector could throw NPE during getRecords() call 
> -----------------------------------------------------------------
>
>                 Key: FLINK-10358
>                 URL: https://issues.apache.org/jira/browse/FLINK-10358
>             Project: Flink
>          Issue Type: Bug
>          Components: Kinesis Connector
>            Reporter: Ying Xu
>            Assignee: Ying Xu
>            Priority: Major
>              Labels: pull-request-available
>
> When extending the flink kinesis connector to consume from a dynamodb stream, it was
found NPE could be thrown at [here|https://github.com/apache/flink/blob/e3c98f05d3544d0165c2d97d2d00fcd295cef8c8/flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/internals/ShardConsumer.java#L376] . 
> This is because the [getRecords API|https://docs.aws.amazon.com/amazondynamodb/latest/APIReference/API_streams_GetRecords.html] in
dynamodb streams does not return the millisBehindLatest field and has it set to null. 
Null check is probably needed here.
> See FLINK-4582 for the context of building dynamodb streams connector on top of the
Kinesis connector. 
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message