flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-10310) Cassandra Sink - Handling failing requests
Date Mon, 24 Sep 2018 08:03:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-10310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16625497#comment-16625497
] 

ASF GitHub Bot commented on FLINK-10310:
----------------------------------------

yanghua commented on a change in pull request #6732: [FLINK-10310] Cassandra Sink - Handling
failing requests.
URL: https://github.com/apache/flink/pull/6732#discussion_r219752224
 
 

 ##########
 File path: flink-connectors/flink-connector-cassandra/src/main/java/org/apache/flink/streaming/connectors/cassandra/NoOpCassandraFailureHandler.java
 ##########
 @@ -0,0 +1,38 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *    http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.streaming.connectors.cassandra;
+
+import org.apache.flink.annotation.Internal;
+
+import java.io.IOException;
+
+/**
+ * A {@link CassandraFailureHandler} that simply fails the sink on any failures.
+ */
+@Internal
+public class NoOpCassandraFailureHandler implements CassandraFailureHandler {
 
 Review comment:
   Oh, I didn't go to see the related implementation of `ElasticsearchSink `. This is just
a suggestion, because when I first saw the name, I thought it was an empty method, didn't
do anything because you called it "NoOp", and in fact you throw an exception, it will cause
the sink task to fail if the outer layer does not handle it. Maybe you can listen to other
people's opinions and see if it is a better choice to keep up with the implementation of `ElasticsearchSink
`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Cassandra Sink - Handling failing requests
> ------------------------------------------
>
>                 Key: FLINK-10310
>                 URL: https://issues.apache.org/jira/browse/FLINK-10310
>             Project: Flink
>          Issue Type: Improvement
>          Components: Cassandra Connector
>            Reporter: Jayant Ameta
>            Priority: Major
>              Labels: pull-request-available
>
> The cassandra sink fails for any kind of error. For some exceptions (e.g WriteTimeoutException),
ignoring the exception may be acceptable as well.
> Can we discuss having a FailureHandler on the lines of ActionRequestFailureHandler?
> http://apache-flink-user-mailing-list-archive.2336050.n4.nabble.com/WriteTimeoutException-in-Cassandra-sink-kill-the-job-tp22706p22707.html



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message