flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-10291) Generate JobGraph with fixed/configurable JobID in StandaloneJobClusterEntrypoint
Date Fri, 28 Sep 2018 14:55:01 GMT

    [ https://issues.apache.org/jira/browse/FLINK-10291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16631963#comment-16631963
] 

ASF GitHub Bot commented on FLINK-10291:
----------------------------------------

tillrohrmann commented on a change in pull request #6733: [FLINK-10291] Generate JobGraph
with fixed/configurable JobID in StandaloneJobClusterEntrypoint
URL: https://github.com/apache/flink/pull/6733#discussion_r221280350
 
 

 ##########
 File path: flink-container/src/test/java/org/apache/flink/container/entrypoint/StandaloneJobClusterEntryPointTest.java
 ##########
 @@ -68,5 +71,6 @@ public void testSavepointRestoreSettings() throws FlinkException {
 		final JobGraph jobGraph = jobClusterEntryPoint.retrieveJobGraph(configuration);
 
 		assertThat(jobGraph.getSavepointRestoreSettings(), is(equalTo(savepointRestoreSettings)));
+		assertEquals(jobGraph.getJobID(), new JobID(0, 0));
 
 Review comment:
   Same here.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Generate JobGraph with fixed/configurable JobID in StandaloneJobClusterEntrypoint
> ---------------------------------------------------------------------------------
>
>                 Key: FLINK-10291
>                 URL: https://issues.apache.org/jira/browse/FLINK-10291
>             Project: Flink
>          Issue Type: Improvement
>          Components: Distributed Coordination
>    Affects Versions: 1.6.0, 1.7.0
>            Reporter: Till Rohrmann
>            Assignee: vinoyang
>            Priority: Critical
>              Labels: pull-request-available
>             Fix For: 1.7.0, 1.6.2
>
>
> The {{StandaloneJobClusterEntrypoint}} currently generates the {{JobGraph}} from the
user code when being started. Due to the nature of how the {{JobGraph}} is generated, it will
get a random {{JobID}} assigned. This is problematic in case of a failover because then, the
{{JobMaster}} won't be able to detect the checkpoints. In order to solve this problem, we
need to either fix the {{JobID}} assignment or make it configurable.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message