flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-10290) Conversion error in StreamScan and BatchScan
Date Fri, 14 Sep 2018 10:00:07 GMT

    [ https://issues.apache.org/jira/browse/FLINK-10290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16614617#comment-16614617
] 

ASF GitHub Bot commented on FLINK-10290:
----------------------------------------

jrthe42 commented on a change in pull request #6666: [FLINK-10290] [table] Fix conversion
error in StreamScan and BatchScan
URL: https://github.com/apache/flink/pull/6666#discussion_r217662930
 
 

 ##########
 File path: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/stream/table/TableSourceITCase.scala
 ##########
 @@ -778,4 +778,42 @@ class TableSourceITCase extends AbstractTestBase {
     assertEquals(expected.sorted, StreamITCase.testResults.sorted)
   }
 
+  @Test
+  def testTableSourceScanWithConversion(): Unit = {
 
 Review comment:
   Agree! Will rename this test.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Conversion error in StreamScan and BatchScan
> --------------------------------------------
>
>                 Key: FLINK-10290
>                 URL: https://issues.apache.org/jira/browse/FLINK-10290
>             Project: Flink
>          Issue Type: Bug
>          Components: Table API &amp; SQL
>    Affects Versions: 1.5.3, 1.6.0
>            Reporter: wangsan
>            Assignee: wangsan
>            Priority: Major
>              Labels: pull-request-available
>
> `RowTypeInfo#equals()` only compares field types, and fields names are not considered.
When checking the equality of `inputType` and `internalType`, we should compare both filed
types and field names.
> Behavior of this bug:
> A table T with schema (a: Long, b:Long, c:Long)
> SELECT b,c,a from T
> expected: b,c,a
> actually: a,b,c



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message