flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-10135) The JobManager doesn't report the cluster-level metrics
Date Tue, 18 Sep 2018 15:13:01 GMT

    [ https://issues.apache.org/jira/browse/FLINK-10135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16619251#comment-16619251
] 

ASF GitHub Bot commented on FLINK-10135:
----------------------------------------

StefanRRichter commented on a change in pull request #6702: [FLINK-10135] The JobManager does
not report the cluster-level metrics
URL: https://github.com/apache/flink/pull/6702#discussion_r218461569
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/Dispatcher.java
 ##########
 @@ -467,6 +467,22 @@ private JobManagerRunner startJobManagerRunner(JobManagerRunner jobManagerRunner
 			});
 	}
 
+	@Override
+	public CompletableFuture<JobsOverview> requestMultipleJobsOverview(Time timeout) {
+		final List<CompletableFuture<Optional<JobStatus>>> optionalJobInformation
= queryJobMastersForInformation(
+			(JobMasterGateway jobMasterGateway) -> jobMasterGateway.requestJobStatus(timeout));
+
+		CompletableFuture<Collection<Optional<JobStatus>>> allOptionalJobsFuture
= FutureUtils.combineAll(optionalJobInformation);
+
+		CompletableFuture<Collection<JobStatus>> allJobsFuture = allOptionalJobsFuture.thenApply(this::flattenOptionalCollection);
 
 Review comment:
   I would simplify as
   
   ```
   		return allOptionalJobsFuture
   			.thenApply(this::flattenOptionalCollection)
   			.thenApply(JobsOverview::create);
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> The JobManager doesn't report the cluster-level metrics
> -------------------------------------------------------
>
>                 Key: FLINK-10135
>                 URL: https://issues.apache.org/jira/browse/FLINK-10135
>             Project: Flink
>          Issue Type: Bug
>          Components: JobManager, Metrics
>    Affects Versions: 1.5.0, 1.6.0, 1.7.0
>            Reporter: Joey Echeverria
>            Assignee: vinoyang
>            Priority: Critical
>              Labels: pull-request-available
>
> In [the documentation for metrics|https://ci.apache.org/projects/flink/flink-docs-release-1.5/monitoring/metrics.html#cluster]
in the Flink 1.5.0 release, it says that the following metrics are reported by the JobManager:
> {noformat}
> numRegisteredTaskManagers
> numRunningJobs
> taskSlotsAvailable
> taskSlotsTotal
> {noformat}
> In the job manager REST endpoint ({{http://<job-manager>:8081/jobmanager/metrics}}),
those metrics don't appear.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message