flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-10065) InstantiationUtil.deserializeObject(InputStream in, ClassLoader cl, boolean isFailureTolerant) will close the inputStream
Date Thu, 20 Sep 2018 09:43:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-10065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16621747#comment-16621747
] 

ASF GitHub Bot commented on FLINK-10065:
----------------------------------------

tzulitai commented on issue #6498: [FLINK-10065] InstantiationUtil.deserializeObject(InputStream
in, ClassLoader cl, boolean isFailureTolerant) will close the inputStream
URL: https://github.com/apache/flink/pull/6498#issuecomment-423115753
 
 
   @tillrohrmann I don't think this was done deliberately, and the changes here looks correct.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> InstantiationUtil.deserializeObject(InputStream in, ClassLoader cl, boolean isFailureTolerant)
will close the inputStream
> -------------------------------------------------------------------------------------------------------------------------
>
>                 Key: FLINK-10065
>                 URL: https://issues.apache.org/jira/browse/FLINK-10065
>             Project: Flink
>          Issue Type: Bug
>            Reporter: Congxian Qiu
>            Assignee: Congxian Qiu
>            Priority: Major
>              Labels: pull-request-available
>
> Now, the implementation of InstantiationUtil.deserializeObject(InputStream in, ClassLoader
cl, boolean isFailureTolerant) isĀ 
> {code:java}
> @SuppressWarnings("unchecked")
> public static <T> T deserializeObject(InputStream in, ClassLoader cl, boolean isFailureTolerant)
> throws IOException, ClassNotFoundException {
> final ClassLoader old = Thread.currentThread().getContextClassLoader();
> // not using resource try to avoid AutoClosable's close() on the given stream
> try (ObjectInputStream oois = isFailureTolerant
> ? new InstantiationUtil.FailureTolerantObjectInputStream(in, cl)
> : new InstantiationUtil.ClassLoaderObjectInputStream(in, cl)) {
> Thread.currentThread().setContextClassLoader(cl);
> return (T) oois.readObject();
> }
> finally {
> Thread.currentThread().setContextClassLoader(old);
> }
> }
> {code}
> InputStream is closable, so the parameter will be closed after call this method.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message