flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-9682) Add setDescription to execution environment and provide description field for the rest api
Date Fri, 28 Sep 2018 08:36:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-9682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16631528#comment-16631528
] 

ASF GitHub Bot commented on FLINK-9682:
---------------------------------------

dawidwys commented on a change in pull request #6266: [FLINK-9682] Add setDescription to execution
environment and provide description field for the rest api
URL: https://github.com/apache/flink/pull/6266#discussion_r221169745
 
 

 ##########
 File path: flink-optimizer/src/main/java/org/apache/flink/optimizer/traversals/PlanFinalizer.java
 ##########
 @@ -76,7 +76,7 @@ public PlanFinalizer() {
 		this.stackOfIterationNodes = new ArrayDeque<IterationPlanNode>();
 	}
 
-	public OptimizedPlan createFinalPlan(List<SinkPlanNode> sinks, String jobName, Plan
originalPlan) {
+	public OptimizedPlan createFinalPlan(List<SinkPlanNode> sinks, String jobName, Plan
originalPlan, String jobDescription) {
 
 Review comment:
   `jobName` and `jobDescription` are not needed anymore.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Add setDescription to execution environment and provide description field for the rest
api
> ------------------------------------------------------------------------------------------
>
>                 Key: FLINK-9682
>                 URL: https://issues.apache.org/jira/browse/FLINK-9682
>             Project: Flink
>          Issue Type: Improvement
>          Components: DataStream API, Webfrontend
>    Affects Versions: 1.5.0
>            Reporter: Elias Levy
>            Assignee: vinoyang
>            Priority: Major
>              Labels: pull-request-available
>
> Currently you can provide a job name to {{execute}} in the execution environment.  In
an environment where many version of a job may be executing, such as a development or test
environment, identifying which running job is of a specific version via the UI can be difficult
unless the version is embedded into the job name given the {{execute}}.  But the job name
is uses for other purposes, such as for namespacing metrics.  Thus, it is not ideal to modify
the job name, as that could require modifying metric dashboards and monitors each time versions
change.
> I propose a new method be added to the execution environment, {{setDescription}}, that
would allow a user to pass in an arbitrary description that would be displayed in the dashboard,
allowing users to distinguish jobs.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message