flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-8799) Make AbstractYarnClusterDescriptor immutable
Date Wed, 19 Sep 2018 11:26:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-8799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16620471#comment-16620471
] 

ASF GitHub Bot commented on FLINK-8799:
---------------------------------------

yanghua commented on issue #5617: [FLINK-8799][YARN] Make AbstractYarnClusterDescriptor immutable
URL: https://github.com/apache/flink/pull/5617#issuecomment-422764603
 
 
   @GJL OK, closing this PR.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Make AbstractYarnClusterDescriptor immutable
> --------------------------------------------
>
>                 Key: FLINK-8799
>                 URL: https://issues.apache.org/jira/browse/FLINK-8799
>             Project: Flink
>          Issue Type: Improvement
>          Components: YARN
>    Affects Versions: 1.5.0
>            Reporter: Gary Yao
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.7.0
>
>
> {{AbstractYarnClusterDescriptor}} should be made immutable. Currently, its internal configuration
is modified from different places which makes it difficult to reason about the code. For example,
it should not be possible to modify the {{zookeeperNamespace}} using a setter method. A user
of this class should be forced to provide all information prior to creating the instance,
e.g., by passing a {{org.apache.flink.configuration.Configuration}} object.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message