flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] xccui commented on a change in pull request #6700: [FLINK-10340][table] Add Cosh math function supported in Table API and SQL
Date Fri, 28 Sep 2018 04:06:41 GMT
xccui commented on a change in pull request #6700: [FLINK-10340][table] Add Cosh math function
supported in Table API and SQL
URL: https://github.com/apache/flink/pull/6700#discussion_r221136490
 
 

 ##########
 File path: docs/dev/table/functions.md
 ##########
 @@ -1274,6 +1274,17 @@ ATAN2(numeric1, numeric2)
       </td>
     </tr>
 
+    <tr>
+      <td>
+        {% highlight text %}
+COSH(numeric)
+{% endhighlight %}
+      </td>
+      <td>
+        <p>Returns the hyperbolic cosine of <i>numeric</i>. Return value
type is DOUBLE.</p>
 
 Review comment:
   1. This page is not a pure markdown doc. We cannot use backquote here.
   2. Conventionally, we use small letters for SQL attributes and capital letters for Java/Scala
attributes.
   3. I don't think the return type should be marked like that. In most cases, it should be
identical to the inputs' types (e.g., if the input is a `bigdecimal`, we should also return
a `begdecimal` instead of a fixed `double`).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message