flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] tillrohrmann commented on issue #6763: [FLINK-10415] Fail response future if connection closes in RestClient
Date Thu, 27 Sep 2018 14:08:00 GMT
tillrohrmann commented on issue #6763: [FLINK-10415] Fail response future if connection closes
in RestClient
URL: https://github.com/apache/flink/pull/6763#issuecomment-425106479
 
 
   Thanks again for the review @zentol. I had to add the `IdleStateHandler` because it happened
sometimes in `RestClientTest#testConnectionClosedHandling` that the channel would not be closed
by Netty after we closed the server socket. So sometimes Netty detects such an event and then
calls `channelInactive` and sometimes not. For the latter case, we need to monitor the connection
for idleness.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message