flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] zentol commented on a change in pull request #6763: [FLINK-10415] Fail response future if connection closes in RestClient
Date Wed, 26 Sep 2018 08:02:19 GMT
zentol commented on a change in pull request #6763: [FLINK-10415] Fail response future if connection
closes in RestClient
URL: https://github.com/apache/flink/pull/6763#discussion_r220461106
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/rest/RestClient.java
 ##########
 @@ -428,6 +447,12 @@ protected void channelRead0(ChannelHandlerContext ctx, Object msg) {
 			ctx.close();
 		}
 
+		@Override
+		public void channelInactive(ChannelHandlerContext ctx) throws Exception {
 
 Review comment:
   doesn't belong to this commit.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message