flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] pnowojski commented on a change in pull request #6299: [FLINK-9713][table][sql] Support processing time versioned joins
Date Thu, 20 Sep 2018 15:33:23 GMT
pnowojski commented on a change in pull request #6299: [FLINK-9713][table][sql] Support processing
time versioned joins
URL: https://github.com/apache/flink/pull/6299#discussion_r219212679
 
 

 ##########
 File path: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/table.scala
 ##########
 @@ -158,36 +158,60 @@ class Table(
 
   /**
     * Creates [[TemporalTableFunction]] backed up by this table as a history table.
-    *
-    * @param timeIndicator field for the [[TemporalTableFunction]]. Must points to a time
indicator
-    * @param primaryKey    field for the [[TemporalTableFunction]].
-    * @return [[TemporalTableFunction]]
+    * Temporal Tables represent a concept of a table that changes over time and for which
+    * Flink keeps track of those changes. [[TemporalTableFunction]] provides a way how to
access
 
 Review comment:
   I would keep `access` because we have in the backlog story that would enable to write following
query:
   ```
   SELECT * FROM Rates('2017/06/14 14:23:12`);
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message