flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] pnowojski commented on a change in pull request #6299: [FLINK-9713][table][sql] Support processing time versioned joins
Date Tue, 18 Sep 2018 15:53:10 GMT
pnowojski commented on a change in pull request #6299: [FLINK-9713][table][sql] Support processing
time versioned joins
URL: https://github.com/apache/flink/pull/6299#discussion_r218374441
 
 

 ##########
 File path: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/logical/operators.scala
 ##########
 @@ -678,6 +678,32 @@ case class WindowAggregate(
   }
 }
 
+case class TemporalTable(
 
 Review comment:
   `Constructor` is inconsistent with other case classes here.
   
   This is behaviour is already quite clearly visible in this class

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message