flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] fhueske commented on a change in pull request #6508: [Flink-10079] [table] Support external sink table in the INSERT INTO clause
Date Sat, 15 Sep 2018 22:45:34 GMT
fhueske commented on a change in pull request #6508: [Flink-10079] [table] Support external
sink table in the INSERT INTO clause 
URL: https://github.com/apache/flink/pull/6508#discussion_r217895759
 
 

 ##########
 File path: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/TableEnvironment.scala
 ##########
 @@ -820,20 +820,59 @@ abstract class TableEnvironment(val config: TableConfig) {
 
   /**
     * Checks if a table is registered under the given name.
+    * Internal and external catalogs are both checked.
     *
     * @param name The table name to check.
     * @return true, if a table is registered under the name, false otherwise.
     */
   protected[flink] def isRegistered(name: String): Boolean = {
 
 Review comment:
   Keep `isRegistered` as it is. It is used be other methods as well.
   We should change the logic in `insertInto` to directly call `getTable()`. This will also
improve the performance, because we only need to talk once to the external catalog (which
might be backed by an external service).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message