flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] kl0u commented on a change in pull request #6646: [FLINK-10050] Support allowedLateness in CoGroupedStreams
Date Fri, 14 Sep 2018 13:48:54 GMT
kl0u commented on a change in pull request #6646: [FLINK-10050] Support allowedLateness in
CoGroupedStreams
URL: https://github.com/apache/flink/pull/6646#discussion_r217716951
 
 

 ##########
 File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/datastream/CoGroupedStreams.java
 ##########
 @@ -254,7 +260,17 @@ protected WithWindow(DataStream<T1> input1,
 		@PublicEvolving
 		public WithWindow<T1, T2, KEY, W> evictor(Evictor<? super TaggedUnion<T1, T2>,
? super W> newEvictor) {
 			return new WithWindow<>(input1, input2, keySelector1, keySelector2, keyType,
-					windowAssigner, trigger, newEvictor);
+					windowAssigner, trigger, newEvictor, allowedLateness);
+		}
+
+		/**
+		 * Sets the time by which elements are allowed to be late.
+		 * @see WindowedStream#allowedLateness(Time)
+		 */
+		@PublicEvolving
+		public WithWindow<T1, T2, KEY, W> allowedLateness(Time newLateness) {
+			return new WithWindow<>(input1, input2, keySelector1, keySelector2, keyType,
 
 Review comment:
   Check for `null`. If the user calls `allowedLateness`, he should not pass a `null` value.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message