flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] twalthr commented on a change in pull request #6299: [FLINK-9713][table][sql] Support processing time versioned joins
Date Fri, 14 Sep 2018 12:16:40 GMT
twalthr commented on a change in pull request #6299: [FLINK-9713][table][sql] Support processing
time versioned joins
URL: https://github.com/apache/flink/pull/6299#discussion_r217393776
 
 

 ##########
 File path: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/calcite/RelTimeIndicatorConverter.scala
 ##########
 @@ -400,6 +411,10 @@ class RexTimeIndicatorMaterializer(
     // materialize operands with time indicators
     val materializedOperands = updatedCall.getOperator match {
 
+      case tableFunction: TableSqlFunction
 
 Review comment:
   Additionally, for the future event-time case, add a dedicated test case to `TimeAttributesITCase`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message