flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] StefanRRichter commented on a change in pull request #6491: [FLINK-10057] Update FlinkYarnSessionCli.java
Date Tue, 11 Sep 2018 14:31:38 GMT
StefanRRichter commented on a change in pull request #6491: [FLINK-10057] Update FlinkYarnSessionCli.java
URL: https://github.com/apache/flink/pull/6491#discussion_r216691558
 
 

 ##########
 File path: flink-yarn/src/main/java/org/apache/flink/yarn/cli/FlinkYarnSessionCli.java
 ##########
 @@ -530,6 +530,11 @@ protected Configuration applyCommandLineOptionsToConfiguration(CommandLine
comma
 	private boolean isYarnPropertiesFileMode(CommandLine commandLine) {
 		boolean canApplyYarnProperties = !commandLine.hasOption(addressOption.getOpt());
 
+		// if canApplyYarnProperties is false,return quickly !
 
 Review comment:
   Please add a space after comma in the comment.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message