From issues-return-183420-archive-asf-public=cust-asf.ponee.io@flink.apache.org Thu Aug 9 08:30:04 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id DD707180676 for ; Thu, 9 Aug 2018 08:30:03 +0200 (CEST) Received: (qmail 29945 invoked by uid 500); 9 Aug 2018 06:30:03 -0000 Mailing-List: contact issues-help@flink.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.apache.org Delivered-To: mailing list issues@flink.apache.org Received: (qmail 29932 invoked by uid 99); 9 Aug 2018 06:30:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 09 Aug 2018 06:30:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id A69DAC83A8 for ; Thu, 9 Aug 2018 06:30:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.501 X-Spam-Level: X-Spam-Status: No, score=-109.501 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id Wcm1WUcylDVO for ; Thu, 9 Aug 2018 06:30:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 67BFA5F42E for ; Thu, 9 Aug 2018 06:30:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 9BACEE12FE for ; Thu, 9 Aug 2018 06:30:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 4F1A423F9E for ; Thu, 9 Aug 2018 06:30:00 +0000 (UTC) Date: Thu, 9 Aug 2018 06:30:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@flink.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (FLINK-10101) Mesos web ui url is missing. MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/FLINK-10101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16574351#comment-16574351 ] ASF GitHub Bot commented on FLINK-10101: ---------------------------------------- yanghua commented on a change in pull request #6522: [FLINK-10101][mesos] Add web ui url for mesos. URL: https://github.com/apache/flink/pull/6522#discussion_r208818211 ########## File path: flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/MesosResourceManager.java ########## @@ -120,6 +120,9 @@ /** A local actor system for using the helper actors. */ private final ActorSystem actorSystem; + /** Web url for to show in mesos page.*/ + @Nullable private final String webUiUrl; Review comment: for field, I recommend `@Nullable` to move up one line ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org > Mesos web ui url is missing. > ---------------------------- > > Key: FLINK-10101 > URL: https://issues.apache.org/jira/browse/FLINK-10101 > Project: Flink > Issue Type: Bug > Components: Mesos > Affects Versions: 1.5.0, 1.5.1, 1.5.2 > Reporter: Renjie Liu > Assignee: Renjie Liu > Priority: Major > Labels: pull-request-available > > Mesos web ui url is missing in new deploy mode. -- This message was sent by Atlassian JIRA (v7.6.3#76005)